fix(routing): sweep remaining app-entry links onto package-id segment (ADR-0048)#1719
Merged
Merged
Conversation
… (ADR-0048) Follow-up to the home-page fix (#1717): - AppManagementPage "Open app" button opens /apps/<packageId> (app._packageId ?? app.name), not /apps/<name>. - AppContent current-app sub-routes/redirects (metadata/package redirect, record-form baseUrl) build against the URL's own appName segment instead of activeApp.name, so a /apps/<packageId>/ URL keeps its segment. requestedAppMissing uses matchAppBySegment so a package-id URL isn't flagged as a missing app. Verified in the browser: System > Apps > Open Showcase > /apps/com.example.showcase/showcase_project (app loads). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1717 (home-page app links). Swept the console for app-entry links still building
/apps/<app.name>instead of the canonical package-id segment.Fixed
/apps/${app.name}→/apps/${app._packageId ?? app.name}.activeApp.name(which flipped a/apps/<packageId>/…URL to the name form):metadata/package→component/developer/packagesredirect (path matcher + target),baseUrl,appNameroute param.requestedAppMissing(preview-drafts) now resolves viamatchAppBySegment, so a package-id URL isn't mistaken for a missing app.Left deliberately
ConsoleFloatingChatbot"open just-published app" — itspublishedpayload is{type, name}with no_packageId, so name-form is the only option (andmatchAppBySegmentfalls back to name).appName-from-useParams()sub-route builders (RecordFormPage, ObjectView, marketplace pages, …) — they correctly reuse the current segment.Verification
Browser (dev console against a live backend): System → Apps → Open Showcase →
/apps/com.example.showcase/showcase_project, app renders. Typecheck clean for both packages.🤖 Generated with Claude Code